Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for ESM5 autoInjectable. #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Saneesh-B
Copy link

Fix "Class constructor XXX cannot be invoked without 'new'" when in ESM5. This happens in Vue and React

@Saneesh-B
Copy link
Author

@microsoft-github-policy-service agree company="Identy"

@MeltingMosaic
Copy link
Collaborator

This is kind of a big change to the basic autoInjectable functionality, and introduces reflection via Proxy - I wonder if we should have a new decorator for the Vue/React case?

@Saneesh-B
Copy link
Author

Saneesh-B commented Jan 31, 2024

@MeltingMosaic I wanted to make it generic to all frameworks. Im okay either way.

@Saneesh-B
Copy link
Author

Ideas on how to proceed ?

@risen228
Copy link

Should be working in my fork: tsyringe-neo

@Saneesh-B
Copy link
Author

@risen228 , i have it working in my fork :). Just this is taking a whole lot of time to get some attention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants